Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: Added unknown Croatian ingredients to the taxonomy (part 10) #9244

Merged
merged 10 commits into from
Nov 30, 2023

Conversation

benbenben2
Copy link
Collaborator

What

added HR in taxonomy

Related issue(s) and discussion

  • Fixes #-none-

@benbenben2 benbenben2 self-assigned this Nov 5, 2023
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗 Ingredients 🧪 additives 🥜 Allergens labels 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis labels Nov 5, 2023
@teolemon teolemon added the 🇭🇷 Croatia https://hr.openfoodfacts.org/ label Nov 6, 2023
@benbenben2 benbenben2 marked this pull request as ready for review November 7, 2023 16:47
@benbenben2 benbenben2 requested a review from a team as a code owner November 7, 2023 16:47
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0234c56) 48.68% compared to head (73a6ff2) 48.67%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9244      +/-   ##
==========================================
- Coverage   48.68%   48.67%   -0.01%     
==========================================
  Files          65       65              
  Lines       20268    20268              
  Branches     4896     4896              
==========================================
- Hits         9867     9866       -1     
  Misses       9141     9141              
- Partials     1260     1261       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon changed the title taxonomy: Tax hr unknown ingred 10 taxonomy: Added unknown Hungarian ingredients to the taxonomy (part 10) Nov 9, 2023
sl:Glavnih Ribolovnih Območij FAO
sv:FAO:s Fiskeregioner
xx:FAO major fishing areas
description:en:European Union, FAO major fishing areas
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that this is also addressed in the origins taxonomy

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing it out

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed them from labels and added synonyms in origins instead.

@benbenben2 benbenben2 changed the title taxonomy: Added unknown Hungarian ingredients to the taxonomy (part 10) taxonomy: Added unknown Croatian ingredients to the taxonomy (part 10) Nov 10, 2023
@github-actions github-actions bot added 📍 Origins Origins are used for Eco-Score computation. We want to have structured origins. Additives labels Nov 10, 2023
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot !

@alexgarel alexgarel merged commit 992aa36 into main Nov 30, 2023
13 checks passed
@alexgarel alexgarel deleted the tax_hr_unknown_ingred_10 branch November 30, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 additives 🥜 Allergens Allergens 🇭🇷 Croatia https://hr.openfoodfacts.org/ 🐠 Fishing 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients ingredients labels 📍 Origins Origins are used for Eco-Score computation. We want to have structured origins. 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants